Warn on implicit switch case fallthrough #10074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems to have found one actual bug in fs-sink.cc: the symlink case was falling into the regular file case, which can't possibly be intentional, right?
edolstra
reviewed
Feb 26, 2024
| @@ -38,6 +39,7 @@ void copyRecursive( | |||
| sink, to + "/" + name); | |||
| break; | |||
There was a problem hiding this comment.
We can also remove this break since it does nothing.
There was a problem hiding this comment.
nope the compiler is a big fool and can't figure that out unfortunately. i tried :)
thufschmitt
approved these changes
Feb 26, 2024
There was a problem hiding this comment.
Good thing to have, indeed :)
The bug you fixed scared me to death at first because I thought that we'd been generating twisted Nar files since potentially the beginning of Nix. But it turns out that this copyRecursive function is actually dead code :)
Nearly the whole of libutil/git.{cc,hh} is actually dead code, I'll remove it in a subsequent PR
tebowy
pushed a commit
to tebowy/nix
that referenced
this pull request
Jul 11, 2024
Warn on implicit switch case fallthrough (cherry picked from commit 21282c3) Change-Id: I5ebbdfb6c037d2c55254f37dd391c07c2ce7443e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to have found one actual bug in fs-sink.cc: the symlink case was falling into the regular file case, which can't possibly be intentional, right?
Motivation
Trivially easy to do, catches bugs, doesn't degrade dev experience (just use
[[fallthrough]],// fall through, etc to disable it if it's deliberate).Context
https://docs.jade.fyi/gnu/gcc/gcc.html#index-Wimplicit_002dfallthrough_003d
Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.