Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetcher cleanups #10152

Merged
merged 3 commits into from
Mar 7, 2024
Merged

Fetcher cleanups #10152

merged 3 commits into from
Mar 7, 2024

Conversation

edolstra
Copy link
Member

@edolstra edolstra commented Mar 4, 2024

Motivation

Some lazy-trees backports:

  • Convert all InputScheme::fetch() methods to getAccessor().

  • Add checkLocks() method for checking lock attributes.

  • Rename fetch() to fetchToStore().

Depends on #10151.

Context

Priorities and Process

Add 👍 to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.

Using the relative path can cause collisions between cache entries for
PosixSourceAccessors with different roots.
@github-actions github-actions bot added new-cli Relating to the "nix" command fetching Networking with the outside (non-Nix) world, input locking labels Mar 4, 2024
edolstra added 2 commits March 4, 2024 22:24
* Convert all InputScheme::fetch() methods to getAccessor().

* Add checkLocks() method for checking lock attributes.

* Rename fetch() to fetchToStore().
Copy link

dpulls bot commented Mar 5, 2024

🎉 All dependencies have been resolved !

@edolstra edolstra merged commit 7d76bc8 into NixOS:master Mar 7, 2024
8 checks passed
@edolstra edolstra deleted the fetcher-cleanups branch March 7, 2024 09:21
edolstra added a commit that referenced this pull request Mar 7, 2024
This wasn't caught by CI because #10149 and #10152 pass
individually... It doesn't happen on lazy-trees either because we
never try to fetch relative path flakes (#10089).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fetching Networking with the outside (non-Nix) world, input locking new-cli Relating to the "nix" command
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant