Add functional tests for include directives in nix config file #10386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
with-tests
Ericson2314
reviewed
Apr 3, 2024
| @@ -56,4 +66,4 @@ exp_features=$(nix config show | grep '^experimental-features' | cut -d '=' -f 2 | |||
| # Test that it's possible to retrieve a single setting's value | |||
| val=$(nix config show | grep '^warn-dirty' | cut -d '=' -f 2 | xargs) | |||
| val2=$(nix config show warn-dirty) | |||
| [[ $val == $val2 ]] | |||
| [[ $val == $val2 ]] | |||
There was a problem hiding this comment.
Note we conventionally have trailing newlines
Ericson2314
reviewed
Apr 3, 2024
Comment on lines
+52
to
+53
| export NIX_USER_CONF_FILES=$here/config/nix-with-bang-include.conf | ||
| var=$(nix config show | grep '^experimental-features =' | cut -d '=' -f 2 | xargs) |
There was a problem hiding this comment.
var=$(NIX_USER_CONF_FILES=$here/config/nix-with-bang-include.conf nix config show | grep '^experimental-features =' | cut -d '=' -f 2 | xargs)I would do it this way so it doesn't interfere with the other tests
Ericson2314
reviewed
Apr 3, 2024
Comment on lines
+47
to
+48
| export NIX_USER_CONF_FILES=$here/config/nix-with-include.conf | ||
| var=$(nix config show | grep '^allowed-uris =' | cut -d '=' -f 2 | xargs) |
There was a problem hiding this comment.
Ericson2314
reviewed
Apr 3, 2024
| @@ -0,0 +1,2 @@ | |||
| experimental-features = nix-command | |||
There was a problem hiding this comment.
I would do a test like
system = asdf
because experimental-features is much more likely to interfere with the test suite itself
|
@SkamDart Thank you for quickly taking on this issue! It's certainly better than it was before, but these are a few small things that I think would make it better still. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Add two tests for the
!includeandincludedirectives used in nix.confhttps://github.com/NixOS/nix/pull/10358/files
Context
Resolves #10383
Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.