Remove unused operator<=>'s that darwin can't generate
#11091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was complaining *a lot*, with dozens of MB of logs.
Ericson2314
previously requested changes
Jul 12, 2024
There was a problem hiding this comment.
Can we make Darwin generate them instead somehow? Because #10838 needs a fix for that, and if we can solve it for this, then we might as well keep these for testing.
(I thought they were already needed for testing!)
It doesn't have a This is easy enough to revert, or re-add, and makes the build log usable again. I was unable to find the build problem with #11021 without this. |
roberth
dismissed
Ericson2314’s stale review
Sorry, fixing the build log is more important
roberth
added
the
contributor-experience
edolstra
approved these changes
Jul 12, 2024
Ericson2314
approved these changes
Jul 12, 2024
|
I learned the problem is libc++ 16 is just too old. So yeah, we can't do this until Nixpkgs updates to a newer LLVM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
It was complaining a lot, with dozens of MB of logs.
Context
Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.