Grep newline safety #11111
Merged
Grep newline safety #11111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Newlines behave like *OR*; not "and then".
github-actions
bot
added
the
with-tests
|
@GoldsteinE Great job with the other one. Would you like to review this? |
GoldsteinE
approved these changes
Jul 16, 2024
It gives access to a stack trace basically. It's not the prettiest code I've written, but it has a test and it's not critical, so I think we'll be fine. |
Ericson2314
reviewed
Jul 16, 2024
tomberek
reviewed
Jul 22, 2024
Co-authored-by: tomberek <tomberek@users.noreply.github.com>
Ericson2314
reviewed
Jul 25, 2024
Ericson2314
approved these changes
Jul 25, 2024
Co-authored-by: John Ericson <John.Ericson@Obsidian.Systems>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Newlines in the query behave like OR; not "and then".
Context
Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.