Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change skipped test error code from 99 to 77 #11177

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

Ericson2314
Copy link
Member

Motivation

Meson uses a venerable GNU convention described in https://www.gnu.org/software/automake/manual/html_node/Scripts_002dbased-Testsuites.html in which:

When no test protocol is in use, an exit status of 0 from a test
script will denote a success, an exit status of 77 a skipped test, an
exit status of 99 a hard error, and any other exit status will denote
a failure.

77 is thus what we want, not 99.

Context

#2503

Priorities and Process

Add 👍 to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.

Meson uses a venerable GNU convention described in
https://www.gnu.org/software/automake/manual/html_node/Scripts_002dbased-Testsuites.html
in which:

> When no test protocol is in use, an exit status of 0 from a test
> script will denote a success, an exit status of 77 a skipped test, an
> exit status of 99 a hard error, and any other exit status will denote
> a failure.

77 is thus what we want, not 99.
@github-actions github-actions bot added the with-tests Issues related to testing. PRs with tests have some priority label Jul 25, 2024
@Ericson2314 Ericson2314 added the contributor-experience Developer experience for Nix contributors label Jul 25, 2024
@roberth roberth merged commit 6662c90 into NixOS:master Jul 25, 2024
13 checks passed
@Ericson2314 Ericson2314 deleted the skip-exit-code branch July 25, 2024 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor-experience Developer experience for Nix contributors with-tests Issues related to testing. PRs with tests have some priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants