Fix diskutil deleteVolume command in Uninstall guide

[secobarbital]

Motivation

The uninstall guide had an incorrect command to delete the Nix Store volume on MacOS. It is correct in one place but wrong in the other.

The guide also suggests to copy the backup copies of the system shell rc files if they had not been modified since the Nix install, but there is no way to know if that is the case, so I think it is better to just have the user remove the daemon.sh lines.

Context

Priorities and Process

Add 👍 to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.

[fricklerhandwerk]

Of course there's a way to check if something changed: diff the backup file with the current file and check if only the Nix block stands out. :)

The new state of the document would not mention the backup files any more and probably lead to users keeping them around.

If you make a separate PR for the apfs command fix, I can merge that immediately. Thanks for catching that! The other part needs a bit more thought.

[secobarbital]

Of course there's a way to check if something changed: diff the backup file with the current file and check if only the Nix block stands out. :)

The new state of the document would not mention the backup files any more and probably lead to users keeping them around.

I took out the backup file parts so we can merge the apfs change with this PR.

My problem with the rc files instruction is that Apple changes them on Mac OS upgrades so people may not realize that they changed and blindly overwrite them with the backup files.

I wonder if the instruction was targeted at people uninstalling after trying nix out for a few hours vs I want to change it to avoid confusing my colleagues who I had convinced a while back to install nix for our dev env and now uninstalling to use the Determinate Systems Installer but the latter fails on the Nox Store volume.

I’m sure we can come up with wording to satisfy both.

[fricklerhandwerk]

The instructions were written before the whole store volume thing came up. Much of the material all around is older than you think. Would be happy to review or discuss proposals for improving this stuff. Maybe it could be as easy as running diff or a some other rather simple commands to check for changes.