Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch Git submodules lazily #11425

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

edolstra
Copy link
Member

@edolstra edolstra commented Sep 4, 2024

Motivation

This isn't particularly useful right now, since we still copy the entire Git input to the store. But once we have lazy trees, this will avoid fetching submodules unless they're actually needed.

Note: submodules in workdirs are not lazy yet.

Context

Priorities and Process

Add 👍 to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.

This isn't particularly useful right now, since we still copy the
entire Git input to the store. But once we have lazy trees, this will
avoid fetching submodules unless they're actually needed.
@github-actions github-actions bot added the fetching Networking with the outside (non-Nix) world, input locking label Sep 4, 2024
@roberth roberth marked this pull request as draft September 7, 2024 22:34
@roberth
Copy link
Member

roberth commented Sep 7, 2024

Looks alright overall, but can't be tested until we have at least

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fetching Networking with the outside (non-Nix) world, input locking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants