Fix help test in dev shell #11900
Open
Fix help test in dev shell #11900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure what the intent was expecting help.sh to fail in the main suite, but it caused `meson test` to fail inside a `nix develop` shell: $ meson test help --print-errorlogs ninja: Entering directory `/home/eelco/Dev/nix-master/build' 1/1 nix-functional-tests:main / help UNEXPECTEDPASS 4.02s
github-actions
bot
added
the
with-tests
edolstra
force-pushed
the
fix-help-test
branch
from
58dd18b to
9c6f528
Compare
roberth
reviewed
Nov 19, 2024
| @@ -167,7 +167,7 @@ suites = [ | |||
| 'impure-env.sh', | |||
| 'debugger.sh', | |||
| 'extra-sandbox-profile.sh', | |||
| 'help.sh', | |||
| #'help.sh', | |||
There was a problem hiding this comment.
I don't think we want to exclude it unconditionally.
Suggested change
| #'help.sh', | |
| 'help.sh', |
There was a problem hiding this comment.
Unfortunately one of the VM tests fails without this, see https://github.com/NixOS/nix/actions/runs/11895552419/job/33145394782.
There was a problem hiding this comment.
Discussed in meeting
Possible solutions
- add
nix-manual.manmanpages to NixOS testcommon.nix<= preferred - add
nix(everything.nix) preferably not because that includes the functional tests - add a meson option to disable
help.sh
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2024-12-16-nix-team-meeting-minutes-203/57483/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Not sure what the intent was expecting help.sh to fail in the main suite, but it caused
meson testto fail inside anix developshell:Probably the condition should be something like
but we can't access the
doc-genoption intests/functional/meson.build....Context
Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.