Add support for unicode escape sequences in fromJSON #3305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As fromTOML supports \u and \U escapes, bring fromJSON on par. As JSON defaults to UTF-8 encoding (every JSON parser must support UTF-8), this change parses the `\u hex hex hex hex` sequence (\u followed by 4 hexadecimal digits) into an UTF-8 representation. Add a test to verify correct parsing, using all escape sequences from json.org.
|
Thanks! |
dtzWill
pushed a commit
to dtzWill/nix
that referenced
this pull request
Jan 7, 2020
…rings Add support for unicode escape sequences in fromJSON (cherry picked from commit 04bbfa6)
|
As far as I can tell, this code has not been released yet. When will it be included in a release? Will/can it be back-ported to 2.3? |
Closed
2 tasks
horriblename
pushed a commit
to horriblename/nmd
that referenced
this pull request
Oct 4, 2023
Support for Unicode escape sequences (`\uabcd`) was added to Nix in version 2.4 (NixOS/nix#3305), so in order to maintain compatibility with 2.3 (which IMO is debatable) we should output non-ASCII characters as-is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As fromTOML supports unicode escape sequences, bring fromJSON on par. JSON defaults
to UTF-8 encoding (every JSON parser must support UTF-8), thus this change parses the
u hex hex hex hexsequence (escapedufollowed by 4 hexadecimal digits) into anUTF-8 representation.
Add a test to verify correct parsing, using all escape sequences from json.org.
Caught by @basvandijk while debugging Hydra issue, where JSON strings coming from GitHub contained
\ u(on purpose written with a space in between to avoid this Hydra issue), which prevented the evaluation of any jobset in a project, as JSON parsing was failing.Fixes #2257