Remove rsync usage in the installer #5150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domenkozar
force-pushed
the
install-no-rsync
branch
from
0b986cf to
b1c5fb3
Compare
domenkozar
force-pushed
the
install-no-rsync
branch
from
b1c5fb3 to
70ce6d1
Compare
It's not commonly installed on systems like debian, so avoid the bootstrapping problem by using cp and chmod.
domenkozar
force-pushed
the
install-no-rsync
branch
from
70ce6d1 to
475fc10
Compare
|
Tested at https://github.com/domenkozar/test-cachix-installer/runs/3369467883?check_suite_focus=true using Debian self-hosted runner (that previously failed due to rsync missing). |
|
Another benefit is smaller Nix closure for self-contained statically linked Nix. |
This was referenced Jun 14, 2022
abathur
added a commit
to abathur/nix
that referenced
this pull request
Jun 16, 2022
Before NixOS#5150 the copy-to-store phase of the install was idempotent, but the recursive cp isn't. This is probably baiting a few people into trying corrective installs that will fail.
abathur
added a commit
to abathur/nix
that referenced
this pull request
Jun 28, 2022
Before NixOS#5150 the copy-to-store phase of the install was idempotent, but the recursive cp isn't. This is probably baiting a few people into trying corrective installs that will fail.
abathur
added a commit
to abathur/nix
that referenced
this pull request
Jun 30, 2022
Before NixOS#5150 the copy-to-store phase of the install was idempotent, but the recursive cp isn't. This is probably baiting a few people into trying corrective installs that will fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not commonly installed on systems like debian,
so avoid the bootstrapping problem by using cp and
chmod.
Not tested yet.See comment below.Fixes #2437