Allow installing multi-user as root on macOS and Linux #6882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grahamc
commented
Aug 8, 2022
| sudo "$@" | ||
|
|
||
| if is_root; then | ||
| env "$@" |
There was a problem hiding this comment.
Note this uses env because some _sudo callsites pass environment variables to the program being executed.
cole-h
reviewed
Aug 9, 2022
grahamc
force-pushed
the
allow-multi-user-as-root
branch
from
e4a67b9 to
7bb1e91
Compare
|
Tested the resulting installer, I think this is good to go. |
grahamc
changed the title
|
You need a MacBook Air to test it? I. An fedex you one to try I have a few lying around I been hoarding them and raid ing costxo |
|
It would be great to test this on macOS as root, but I'll merge it since it shouldn't break existing usage. |
|
FYI: it was tested on an x86 macOS VM (not aarch64 or on real hardware, but hopefully a close enough approximation?): #6882 (comment). So, ideally, everything should be fine. |
|
I tested this on an aarch64 mac through MDM and it worked great! |
Minion3665
pushed a commit
to Minion3665/nix
that referenced
this pull request
Feb 23, 2023
…r-as-root Allow installing multi-user as root on macOS and Linux
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may work fine on a mac, but I don't have one for testing. I haven't tested this exact change on Linux yet, but it operates on the idea that you can "just" set EUID=65535 as root and the installer works fine. Going to test this shortly.
Closes #6801, cc @cole-h.