add flake-compat to flake.nix and use sha256 in default.nix #7989
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Make default.nix pure
Context
Forum thread
I have no idea why default.nix was used at all when referring to the package from a flake. However, as adding flake-compat to flake.nix is the way the its (and nix') author recommend using it, I don't see the harm of doing exactly that to ensure default.nix works when called in pure evaluation mode, even if few people actually need to do this.
Advantages:
Disadvantages:
Checklist for maintainers
Maintainers: tick if completed or explain if not relevant
tests/**.sh
src/*/tests
tests/nixos/*
Priorities
Add 👍 to pull requests you find important.