Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test and begin documentation of the ATerm format for derivations #8927

Merged
merged 2 commits into from
Sep 6, 2023

Conversation

Ericson2314
Copy link
Member

Motivation

Wanted to do this before the last dynamic derivations PR when I introduce a variation, to make sure I wasn't changing the old version by mistake.

Context

#4628 is the next one.

Priorities

Add 👍 to pull requests you find important.

Wanted to do this before the last dynamic derivations PR when I
introduce a variation, to make sure I wasn't changing the old version by
mistake.
@github-actions github-actions bot added the with-tests Issues related to testing. PRs with tests have some priority label Sep 5, 2023
Derivations are serialised in the following format:

```
Derive(...)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This surely needs a bit more detail

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The next PR will had some more detail. I just wanted to put something here to have a clear diff.

doc/manual/src/SUMMARY.md.in Outdated Show resolved Hide resolved
doc/manual/src/protocols/derivation-aterm.md Outdated Show resolved Hide resolved
Copy link
Member

@roberth roberth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would commit it for you but policy prohibits that in this PR.

Co-authored-by: Robert Hensing <roberth@users.noreply.github.com>
@Ericson2314 Ericson2314 merged commit 7545282 into NixOS:master Sep 6, 2023
@Ericson2314 Ericson2314 deleted the test-derivation-aterm branch September 6, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
with-tests Issues related to testing. PRs with tests have some priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants