Shuffle ParseSink code in preparation for git hashing support
#9024
Conversation
Ericson2314
changed the title
ParseSink code in preparation for git hashing supportParseSink code in preparation for git hashing support
Co-Authored-By: Matthew Bauer <mjbauer95@gmail.com> Co-Authored-By: Carlo Nucera <carlo.nucera@protonmail.com>
We will soon add a new implemenation so the one for NARs in `archive.cc` isn't the only one. Co-Authored-By: Matthew Bauer <mjbauer95@gmail.com> Co-Authored-By: Carlo Nucera <carlo.nucera@protonmail.com>
Co-Authored-By: Matthew Bauer <mjbauer95@gmail.com> Co-Authored-By: Carlo Nucera <carlo.nucera@protonmail.com>
Co-Authored-By: Matthew Bauer <mjbauer95@gmail.com> Co-Authored-By: Carlo Nucera <carlo.nucera@protonmail.com>
Ericson2314
force-pushed
the
git-objects-prep
branch
from
c2bdcb9
to
f2e201f
Compare
There was a problem hiding this comment.
Perhaps this should be filesystem.cc, together with other fs utils (to be moved later), considering per-compilation-unit overhead as mentioned in the meeting today.
There was a problem hiding this comment.
Actually I forgot before during the meeting, I really disagree with combining files because it is worse for incremental builds. Latency is most important during development when we are doing incremental builds.
Optimizing non-incremental building is IMO quite a smell. (And we can still have the automatic way of combining files based on number of CPUs if we like.)
There was a problem hiding this comment.
Is that something Meson can do?
optimized for extremely fast full and incremental builds without sacrificing correctness
Couldn't find details about how that is achieved. Maybe you know the right search term?
There was a problem hiding this comment.
No problem, https://mesonbuild.com/Unity-builds.html
Motivation
Setting up existing code for #8918
Context
Tracking issue #8919
Priorities
Add 👍 to pull requests you find important.