Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Git object hashing in libutil #9294

Merged
merged 3 commits into from
Nov 10, 2023
Merged

Git object hashing in libutil #9294

merged 3 commits into from
Nov 10, 2023

Commits on Nov 10, 2023

  1. Create MemorySink 

    This is for writing to a `MemorySourceAccessor`.
    @Ericson2314
    Ericson2314 committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    3d9d5dc View commit details
    Browse the repository at this point in the history

  2. Refactor bash test build system a bit 

    The basic idea here is to separate a few intertwined notions:

1. Not all "run bash tests" are "install tests"

2. Not all "run bash tests" use `tests/functional/init.sh`, or any
   pre-test initialization at all.

This will used in the next commit when we have a test that check unit
test golden master data.

Also, move our custom `PS4` from the test to the test runner, as it is
part of how we want to display the tests, not the test themselves.

Co-authored-by: Robert Hensing <roberth@users.noreply.github.com>
    @Ericson2314 @roberth
    Ericson2314 and roberth committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    9afa697 View commit details
    Browse the repository at this point in the history

  3. Git object hashing in libutil 

    This is the core functionality but just unit-tested and not yet made
part of the store layer. This is because there is some tech debt around
(a) repeated boilerplate hashing objects (b) better integration of the
new `SourceAccessor` type that needs to be cleaned up first.

Part of RFC 133

Co-Authored-By: Matthew Bauer <mjbauer95@gmail.com>
Co-Authored-By: Carlo Nucera <carlo.nucera@protonmail.com>
Co-authored-by: Robert Hensing <roberth@users.noreply.github.com>
Co-authored-by: Florian Klink <flokli@flokli.de>
    @Ericson2314 @matthewbauer
    @meditans @roberth @flokli
    5 people committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    20b95d6 View commit details
    Browse the repository at this point in the history