Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify SourceAccessor methods should never implicitly follow symlinks #9306

Merged
merged 1 commit into from
Dec 9, 2023

Conversation

Ericson2314
Copy link
Member

@Ericson2314 Ericson2314 commented Nov 6, 2023

Motivation

The code has already been fixed (yay!) so what is left of this commit is just updating the API docs.

Context

Priorities

Add 👍 to pull requests you find important.

@Ericson2314
Copy link
Member Author

@edolstra Any idea why resolveSymlinks doesn't appear to be working?

@Ericson2314 Ericson2314 force-pushed the accessor-no-follow-symlink branch 2 times, most recently from fa4beee to 0e6abe3 Compare December 9, 2023 00:56
@Ericson2314 Ericson2314 marked this pull request as ready for review December 9, 2023 00:56
@Ericson2314 Ericson2314 force-pushed the accessor-no-follow-symlink branch 4 times, most recently from 705667e to c580982 Compare December 9, 2023 00:59
The code has already been fixed (yay!) so what is left of this commit is
just updating the API docs.

Co-authored-by: Cole Helbling <cole.e.helbling@outlook.com>
@Ericson2314
Copy link
Member Author

Now that this is just API docs, I'll just merge it.

@Ericson2314 Ericson2314 merged commit 6aba2fd into master Dec 9, 2023
13 checks passed
@Ericson2314 Ericson2314 deleted the accessor-no-follow-symlink branch December 9, 2023 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants