Attach leading comments to the following token #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lucus16
changed the title
Lucus16
force-pushed
the
leading-comments
branch
from
3408e3b to
a3f508e
Compare
Lucus16
force-pushed
the
leading-comments
branch
from
a3f508e to
c8ebd02
Compare
Lucus16
force-pushed
the
leading-comments
branch
from
c3a6ce6 to
5ae8e62
Compare
Lucus16
changed the title
Merged
|
What's the state of this? I've merged this into #118, looking pretty good so far. I think the idempotency issues are not related to the fix, but to the style changes made alongside — after adapting them to the RFC style they went away. |
|
The state is what it says. I need to get around to fixing the idempotence issues before this can be merged. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like this approach will work to fix #32.