Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show channels as buttons (like before) and not in dropdown #92

Closed
davidak opened this issue Jun 11, 2020 · 3 comments · Fixed by #98
Closed

Show channels as buttons (like before) and not in dropdown #92

davidak opened this issue Jun 11, 2020 · 3 comments · Fixed by #98
Assignees
Labels
enhancement New feature or request

Comments

@davidak
Copy link
Member

davidak commented Jun 11, 2020

I don't like hiding information behind a drop down.

Can we have a channel list like ubuntu, like i suggested here?
NixOS/nixos-homepage#209 (comment)

38519355-e35d38b2-3c3f-11e8-87b5-f1167eb05807

@samueldr
Copy link
Member

samueldr commented Jun 11, 2020

I didn't end up mentioning it in the review as I refrained from unnecessary bike shedding, but I agree.

Here's another implementation example:

image

Drop downs, in addition to being hard to wrangle styling-wise, is a poor UX for limited size lists (1-10) and for large lists (50-∞). (For different reasons).

@garbas garbas added the enhancement New feature or request label Jun 12, 2020
@garbas
Copy link
Member

garbas commented Jun 12, 2020

👍 I'm going to change it to what it was before, since I plan to only index 3 channels at all times. And I want to reach current goal (the same functionality as existing search) as soon as possible.

But I think we need add much more search options and before doing any change I would like to collect ideas which options we need to fit next to search input. For this I opened a separate issue (#95) and lets discuss the different search options there.

@garbas
Copy link
Member

garbas commented Jun 12, 2020

I'm going to hijack this ticket and turn it into a proposal that search input looks like in current packages/options search.

@garbas garbas changed the title don't hide channel list Show channels as buttons (like before) and not in dropdown Jun 12, 2020
@garbas garbas self-assigned this Jun 12, 2020
garbas added a commit that referenced this issue Jun 12, 2020
also fixes problem showing result when query is empty string

fixes #92
garbas added a commit that referenced this issue Jun 12, 2020
also fixes problem showing result when query is empty string

fixes #92
garbas added a commit that referenced this issue Jun 12, 2020
also fixes problem showing result when query is empty string

fixes #92
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants