Skip to content

Commit

Permalink
linuxManualConfig: fix inaccurate FIXME comment
Browse files Browse the repository at this point in the history
I read this comment, checked out 4.19, saw that it didn't have any
instances of /bin/pwd, and rejoiced, assuming that the removal must
have been backported to the affected kernels.  But actually, /bin/pwd
was just removed earlier, in 4.15, so kernels older than that are
still affected.

Fix the version number in the comment so I don't go through exactly
the same process again a few months from now next time I'm working on
this file.
  • Loading branch information
alyssais authored and Adam Joseph committed Jul 28, 2023
1 parent b34c60c commit 468f5b6
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pkgs/os-specific/linux/kernel/manual-config.nix
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ let
postPatch = ''
sed -i Makefile -e 's|= depmod|= ${buildPackages.kmod}/bin/depmod|'
# fixup for pre-5.4 kernels using the $(cd $foo && /bin/pwd) pattern
# fixup for pre-4.15 kernels using the $(cd $foo && /bin/pwd) pattern
# FIXME: remove when no longer needed
substituteInPlace Makefile tools/scripts/Makefile.include --replace /bin/pwd pwd
Expand Down

0 comments on commit 468f5b6

Please sign in to comment.