Skip to content

Commit

Permalink
mpich: do not disable gforker by default
Browse files Browse the repository at this point in the history
  • Loading branch information
SomeoneSerge committed Jan 12, 2024
1 parent 4108296 commit 6cccc07
Showing 1 changed file with 16 additions and 4 deletions.
20 changes: 16 additions & 4 deletions pkgs/development/libraries/mpich/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,21 @@
# either libfabric or ucx work for ch4backend on linux. On darwin, neither of
# these libraries currently build so this argument is ignored on Darwin.
, ch4backend
# Process manager to build
, withPm ? "hydra:gforker"
# Process manager to build,
# cf. https://github.com/pmodels/mpich/blob/b80a6d7c24defe7cdf6c57c52430f8075a0a41d6/README.vin#L562-L586
, withPm ? [ "hydra" "gforker" ]
, pmix
, pmixSupport ? true
, pmixSupport ? false
} :

let
processManagers = if builtins.isList withPm then
withPm
else
builtins.filter builtins.isString (builtins.split ":" withPm);
withPm' = builtins.concatStringsSep ":" processManagers;
in

assert (ch4backend.pname == "ucx" || ch4backend.pname == "libfabric");

stdenv.mkDerivation rec {
Expand All @@ -24,7 +33,7 @@ stdenv.mkDerivation rec {

configureFlags = [
"--enable-shared"
"--with-pm=${withPm}"
"--with-pm=${withPm'}"
] ++ lib.optionals (lib.versionAtLeast gfortran.version "10") [
"FFLAGS=-fallow-argument-mismatch" # https://github.com/pmodels/mpich/issues/4300
"FCFLAGS=-fallow-argument-mismatch"
Expand All @@ -48,6 +57,9 @@ stdenv.mkDerivation rec {
'';

meta = with lib; {
# --with-pmix silently disables gforker
broken = ((builtins.elem "gforker" processManagers) && pmixSupport);

description = "Implementation of the Message Passing Interface (MPI) standard";

longDescription = ''
Expand Down

0 comments on commit 6cccc07

Please sign in to comment.