python3Packages.cffi: fix tests on FreeBSD (#329076)

NixOS · Nov 18, 2024 · 7220e35 · 7220e35
2 parents 83b7cf4 + 7778790
commit 7220e35
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 43 deletions.
diff --git a/pkgs/development/python-modules/cffi/clang-pointer-substraction-warning.diff b/pkgs/development/python-modules/cffi/clang-pointer-substraction-warning.diff
diff --git a/pkgs/development/python-modules/cffi/default.nix b/pkgs/development/python-modules/cffi/default.nix
@@ -11,9 +11,6 @@
   pycparser,
 }:
 
-let
-  ccVersion = lib.getVersion stdenv.cc;
-in
 if isPyPy then
   null
 else
@@ -27,35 +24,19 @@ else
       hash = "sha256-HDnGAWwyvEjdVFYZUOvWg24WcPKuRhKPZ89J54nFKCQ=";
     };
 
-    patches =
-      [
-        #
-        # Trusts the libffi library inside of nixpkgs on Apple devices.
-        #
-        # Based on some analysis I did:
-        #
-        #   https://groups.google.com/g/python-cffi/c/xU0Usa8dvhk
-        #
-        # I believe that libffi already contains the code from Apple's fork that is
-        # deemed safe to trust in cffi.
-        #
-        ./darwin-use-libffi-closures.diff
-      ]
-      ++ lib.optionals (stdenv.cc.isClang && (ccVersion == "boot" || lib.versionAtLeast ccVersion "13")) [
-        # -Wnull-pointer-subtraction is enabled with -Wextra. Suppress it to allow the following tests
-        # to run and pass when cffi is built with newer versions of clang (including the bootstrap tools clang on Darwin):
-        # - testing/cffi1/test_verify1.py::test_enum_usage
-        # - testing/cffi1/test_verify1.py::test_named_pointer_as_argument
-        ./clang-pointer-substraction-warning.diff
-      ];
-
-    postPatch = lib.optionalString stdenv.hostPlatform.isDarwin ''
-      # Remove setup.py impurities
-      substituteInPlace setup.py \
-        --replace "'-iwithsysroot/usr/include/ffi'" "" \
-        --replace "'/usr/include/ffi'," "" \
-        --replace '/usr/include/libffi' '${lib.getDev libffi}/include'
-    '';
+    patches = [
+      #
+      # Trusts the libffi library inside of nixpkgs on Apple devices.
+      #
+      # Based on some analysis I did:
+      #
+      #   https://groups.google.com/g/python-cffi/c/xU0Usa8dvhk
+      #
+      # I believe that libffi already contains the code from Apple's fork that is
+      # deemed safe to trust in cffi.
+      #
+      ./darwin-use-libffi-closures.diff
+    ];
 
     nativeBuildInputs = [ pkg-config ];
 
@@ -72,6 +53,11 @@ else
 
     nativeCheckInputs = [ pytestCheckHook ];
 
+    disabledTests = lib.optionals stdenv.hostPlatform.isFreeBSD [
+      # https://github.com/python-cffi/cffi/pull/144
+      "test_dlopen_handle"
+    ];
+
     meta = with lib; {
       changelog = "https://github.com/python-cffi/cffi/releases/tag/v${version}";
       description = "Foreign Function Interface for Python calling C code";