Skip to content

Commit

Permalink
nginx: disable pie on darwin
Browse files Browse the repository at this point in the history
  • Loading branch information
@LnL7
LnL7 committed Sep 12, 2017
1 parent 3c14ef0 commit 734788b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pkgs/servers/http/nginx/generic.nix
View file
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ stdenv.mkDerivation {

preConfigure = (concatMapStringsSep "\n" (mod: mod.preConfigure or "") modules);

hardeningEnable = [ "pie" ];
hardeningEnable = optional (!stdenv.isDarwin) "pie";

postInstall = ''
mv $out/sbin $out/bin
Expand Down

3 comments on commit 734788b

@copumpkin
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does pie ever make sense on Darwin?

@globin
Copy link
Member

@globin globin commented on 734788b Sep 13, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently it should work: https://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20140908/234208.html

But our pie support on darwin probably broke recently, @Ericson2314 is aware of it and working on a fix.

@copumpkin
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, TIL 😄

Please sign in to comment.