Skip to content

Commit

Permalink
hubble: 0.9.0 -> 0.10.0
Browse files Browse the repository at this point in the history
- bump version

- add upstream ldflags

- add myself as a maintainer

- add install check

- disable tests to build

- enable shell completions for unix-like
  • Loading branch information
bryanasdev000 committed Jun 27, 2022
1 parent 904740b commit 8341401
Showing 1 changed file with 28 additions and 3 deletions.
31 changes: 28 additions & 3 deletions pkgs/applications/networking/cluster/hubble/default.nix
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
{ stdenv, lib, buildGoModule, fetchFromGitHub }:
{ stdenv, lib, buildGoModule, fetchFromGitHub, installShellFiles }:

buildGoModule rec {
pname = "hubble";
version = "0.9.0";
version = "0.10.0";

src = fetchFromGitHub {
owner = "cilium";
Expand All @@ -13,11 +13,36 @@ buildGoModule rec {

vendorSha256 = null;

ldflags = [
"-s" "-w"
"-X github.com/cilium/hubble/pkg.GitBranch=none"
"-X github.com/cilium/hubble/pkg.GitHash=none"
"-X github.com/cilium/hubble/pkg.Version=${version}"
];

# Test fails at Test_getFlowsRequestWithInvalidRawFilters in github.com/cilium/hubble/cmd/observe
# https://github.com/NixOS/nixpkgs/issues/178976
# https://github.com/cilium/hubble/pull/656
# https://github.com/cilium/hubble/pull/655
doCheck = false;
doInstallCheck = true;
installCheckPhase = ''
$out/bin/hubble version | grep ${version} > /dev/null
'';

nativeBuildInputs = [ installShellFiles ];
postInstall = ''
installShellCompletion --cmd hubble \
--bash <($out/bin/hubble completion bash) \
--fish <($out/bin/hubble completion fish) \
--zsh <($out/bin/hubble completion zsh)
'';

meta = with lib; {
broken = (stdenv.isLinux && stdenv.isAarch64) || stdenv.isDarwin;
description = "Network, Service & Security Observability for Kubernetes using eBPF";
license = licenses.asl20;
homepage = "https://github.com/cilium/hubble/";
maintainers = with maintainers; [ humancalico ];
maintainers = with maintainers; [ humancalico bryanasdev000 ];
};
}

0 comments on commit 8341401

Please sign in to comment.