Skip to content

Commit

Permalink
recoll: fixup build after libxml2 update
Browse files Browse the repository at this point in the history
  • Loading branch information
@vcunat
vcunat committed Jan 11, 2024
1 parent 8778bc7 commit 8b2d354
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion pkgs/applications/search/recoll/default.nix
View file
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,10 @@ mkDerivation rec {
(lib.withFeature stdenv.isLinux "inotify")
];

env.NIX_CFLAGS_COMPILE = toString [ "-DNIXPKGS" ];
env.NIX_CFLAGS_COMPILE = toString [
"-DNIXPKGS"
"-fpermissive" # libxml2-2.12 changed const qualifiers
];

patches = [
# fix "No/bad main configuration file" error
Expand Down

7 comments on commit 8b2d354

@spiage
Copy link

@spiage spiage commented on 8b2d354 Jan 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello!
I have this issue, could it be after this commit?

error: builder for '/nix/store/aix9lbj2akjg6gggbmgmm531vs36s3x7-virtualbox-7.0.12.drv' failed with exit code 2;
       last 10 log lines:
       > /build/VirtualBox-7.0.12/src/VBox/Runtime/r3/xml.cpp: In member function 'void xml::XmlFileParser::read(const RTCString&, xml::Document&)':
       > /build/VirtualBox-7.0.12/src/VBox/Runtime/r3/xml.cpp:2194:43: error: invalid conversion from 'const xmlError*' {aka 'const _xmlError*'} to 'xmlErrorPtr' {aka '_xmlError*'} [-fpermissive]
       >  2194 |         throw XmlError(xmlCtxtGetLastError(m_ctxt));
       >       |                        ~~~~~~~~~~~~~~~~~~~^~~~~~~~
       >       |                                           |
       >       |                                           const xmlError* {aka const _xmlError*}
       > /build/VirtualBox-7.0.12/src/VBox/Runtime/r3/xml.cpp:134:32: note:   initializing argument 1 of 'xml::XmlError::XmlError(xmlErrorPtr)'
       >   134 | XmlError::XmlError(xmlErrorPtr aErr)
       >       |                    ~~~~~~~~~~~~^~~~
       > kmk: *** [/build/VirtualBox-7.0.12/kBuild/footer-pass2-compiling-targets.kmk:277: /build/VirtualBox-7.0.12/out/linux.amd64/release/obj/RuntimeR3/r3/xml.o] Error 1
       For full logs, run 'nix log /nix/store/aix9lbj2akjg6gggbmgmm531vs36s3x7-virtualbox-7.0.12.drv'.

@spiage
Copy link

@spiage spiage commented on 8b2d354 Jan 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vcunat @sander

@vcunat
Copy link
Member Author

@vcunat vcunat commented on 8b2d354 Jan 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it's not after this commit. It's after libxml2 update. That update caused lots of issues, including the one fixed in this commit.

@spiage
Copy link

@spiage spiage commented on 8b2d354 Jan 12, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
Should I open new issue?

@vcunat
Copy link
Member Author

@vcunat vcunat commented on 8b2d354 Jan 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could, but by itself I don't think it will change anything really.

@spiage
Copy link

@spiage spiage commented on 8b2d354 Jan 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, thank you, I can wait

@vcunat
Copy link
Member Author

@vcunat vcunat commented on 8b2d354 Jan 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solved by #280675

Please sign in to comment.