Skip to content

Commit

Permalink
jupyter_server: Patch unicode test for Darwin (#145993)
Browse files Browse the repository at this point in the history
The test relies on creating and then reading files with unicode names
to/from disk. Apple's HFS+, the default file system until recently, is
unicode-normalizing with normal form D (NFD). So not all unicode file
names round-trip. This patch implements one imperfect solution.

ZHF: #144627
  • Loading branch information
toonn authored Nov 15, 2021
1 parent 73d60f4 commit 9e7f498
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions pkgs/development/python-modules/jupyter_server/default.nix
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
{ lib
, stdenv
, buildPythonPackage
, fetchpatch
, fetchPypi
, pythonOlder
, pytestCheckHook
Expand Down Expand Up @@ -34,6 +35,13 @@ buildPythonPackage rec {
sha256 = "c1f32e0c1807ab2de37bf70af97a36b4436db0bc8af3124632b1f4441038bf95";
};

patches = [ (fetchpatch
{ name = "Normalize-file-name-and-path.patch";
url = "https://github.com/jupyter-server/jupyter_server/pull/608/commits/345e26cdfd78651954b68708fa44119c2ac0dbd5.patch";
sha256 = "1kqz3dyh2w0h1g1fbvqa13q17hb6y32694rlaasyg213mq6g4k32";
})
];

propagatedBuildInputs = [
argon2_cffi
jinja2
Expand Down

0 comments on commit 9e7f498

Please sign in to comment.