Skip to content

Commit

Permalink
cryptomator: fail more gracefully on darwin
Browse files Browse the repository at this point in the history
It was blocking channels since PR #241154 via:
https://hydra.nixos.org/build/231587712/nixlog/1/tail
  • Loading branch information
vcunat committed Aug 12, 2023
1 parent aefe566 commit f045184
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion pkgs/tools/security/cryptomator/default.nix
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{ lib, fetchFromGitHub
{ lib, stdenv, fetchFromGitHub
, autoPatchelfHook
, fuse3
, maven, jdk, makeShellWrapper, glib, wrapGAppsHook
Expand All @@ -10,6 +10,7 @@ let
jdk = jdk;
};
in
assert stdenv.isLinux; # better than `called with unexpected argument 'enableJavaFX'`
mavenJdk.buildMavenPackage rec {
pname = "cryptomator";
version = "1.9.1";
Expand Down

2 comments on commit f045184

@github-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vcunat, you pushed a commit directly to master/release branch
instead of going through a Pull Request.

That's highly discouraged beyond the few exceptions listed
on #118661

@vcunat
Copy link
Member Author

@vcunat vcunat commented on f045184 Aug 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, pushed directly intentionally. tarball job checked locally. (CI is unable to catch this error, sadly.)

Please sign in to comment.