Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkgsCross.*.python3Packages.adblock does not build #247441

Closed
ghost opened this issue Aug 6, 2023 · 1 comment · Fixed by #247442
Closed

pkgsCross.*.python3Packages.adblock does not build #247441

ghost opened this issue Aug 6, 2023 · 1 comment · Fixed by #247442
Labels
0.kind: build failure A package fails to build 6.topic: cross-compilation Building packages on a different platform than they will be used on

Comments

@ghost
Copy link

ghost commented Aug 6, 2023 

$ nix build -f . -L pkgsCross.aarch64-multiplatform.python3Packages.adblock
...
python3.10-adblock>     Finished release [optimized + debuginfo] target(s) in 1m 50s
python3.10-adblock> 📦 Built wheel for abi3 Python ≥ 3.7 to /build/source/target/wheels/adblock-0.6.0-cp37-abi3-linux_x86_64.whl
python3.10-adblock> Finished maturinBuildHook
python3.10-adblock> buildPhase completed in 1 minutes 51 seconds
python3.10-adblock> installing
python3.10-adblock> Executing pipInstallPhase
python3.10-adblock> /build/source/dist /build/source
python3.10-adblock> ERROR: adblock-0.6.0-cp37-abi3-linux_x86_64.whl is not a supported wheel on this platform.
error: build of '/nix/store/l8mnixpj73yc8yijy6xxp3y7x7j36d3j-python3.10-adblock-0.6.0-aarch64-unknown-linux-gnu.drv' on 'ssh://root@192.168.22.102' failed: builder for '/nix/store/l8mnixpj73yc8yijy6xxp3y7x7j36d3j-python3.10-adblock-0.6.0-aarch64-unknown-linux-gnu.drv' failed with exit code 1
error: builder for '/nix/store/l8mnixpj73yc8yijy6xxp3y7x7j36d3j-python3.10-adblock-0.6.0-aarch64-unknown-linux-gnu.drv' failed with exit code 1;
       last 10 log lines:
       >    Compiling adblock v0.6.0 (/build/source)
       >     Finished release [optimized + debuginfo] target(s) in 1m 50s
       > 📦 Built wheel for abi3 Python ≥ 3.7 to /build/source/target/wheels/adblock-0.6.0-cp37-abi3-linux_x86_64.whl
       > Finished maturinBuildHook
       > buildPhase completed in 1 minutes 51 seconds
       > installing
       > Executing pipInstallPhase
       > /build/source/dist /build/source
       > ERROR: adblock-0.6.0-cp37-abi3-linux_x86_64.whl is not a supported wheel on this platform.
       >
       For full logs, run 'nix log /nix/store/l8mnixpj73yc8yijy6xxp3y7x7j36d3j-python3.10-adblock-0.6.0-aarch64-unknown-linux-gnu.drv'.
@ghost ghost added the 0.kind: bug Something is broken label Aug 6, 2023
@ghost ghost self-assigned this Aug 6, 2023
@ghost ghost mentioned this issue Aug 6, 2023
Merged
3 tasks
@ghost ghost linked a pull request Aug 6, 2023 that will close this issue
rust: hooks: fix cross compilation #247442
Merged
3 tasks
alyssais pushed a commit that referenced this issue Sep 26, 2023
@alyssais
rust: hooks: fix cross compilation
67a4f82 
Currently there is a state of severe confusion in
pkgs/build-support/rust/hooks/ regarding host vs target; right now
there is only "host" defined, but whether it means "host" or
"target" seems to fluctuate.

This commit corrects that, ensuring that all variables come in all
three flavors (build, host, target) and are used consistently with
the nixpkgs convention.

This also fixes the cross-compilation of packages which use
`maturinBuildHook` -- hooks go in `nativeBuildInputs` and are
phase-shifted backwards by one platform, so they need to be careful
about distinguishing between build and host.

Closes #247441
@FliegendeWurst FliegendeWurst added 0.kind: build failure A package fails to build 6.topic: cross-compilation Building packages on a different platform than they will be used on and removed 0.kind: bug Something is broken labels Oct 19, 2023
@FliegendeWurst
Copy link
Member

Fixed by #247442

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0.kind: build failure A package fails to build 6.topic: cross-compilation Building packages on a different platform than they will be used on
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rust: hooks: fix cross compilation
1 participant
@FliegendeWurst