-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove cruft from platform descriptions #34274
Comments
I have a PR in the works (should be ready tomorrow) that allows to do
which makes for a much better experience as it looks more like your typical derivation. |
@teto I'd say only leave things for kernel headers there, as that actually effects everything (on Linux). |
I agree for refactoring |
I made some WIP stuff for the kernel one time: https://github.com/NixOS/nixpkgs/compare/master...dezgeg:kernel-plat-fix?expand=1, but IIRC some of the kernels failed to boot during runtime, still need to debug that one day. |
glibc removed the underlying flag in 2011 in 83cd14204559abbb52635006832eaf4d2f42514a [1]. This gets us one step closer to fixing NixOS#34274: the cross stdenv for aarch64-unknown-linux-gnu at least evals now. Thanks to @dezgeg for doing all the research for this. [1]: https://sourceware.org/git/?p=glibc.git;a=commit;h=83cd14204559abbb52635006832eaf4d2f42514a
glibc removed the underlying flag in 2011 in 83cd14204559abbb52635006832eaf4d2f42514a [1]. This gets us one step closer to fixing #34274: the cross stdenv for aarch64-unknown-linux-gnu at least evals now. Thanks to @dezgeg for doing all the research for this. [1]: https://sourceware.org/git/?p=glibc.git;a=commit;h=83cd14204559abbb52635006832eaf4d2f42514a
Per #34645 (comment) @dtzWill and I need to figure out whether to moved |
For what it's worth, I've started using just the "config" in my cross specifications and so far so good! I don't cross-build kernels as part of my work or testing, and I note that is the remaining TODO item :). Just wanted to chime in that the rest is in a good place! Minor convenience thing: it's annoying to specify |
@dtzWill Maybe we can get made issue: NixOS/nix#1850 |
@Ericson2314 thanks for the issue, and agreed not priority for nix update. I was just wanting to discuss it to see what you had in mind. I'll follow that issue, neat idea! I agree we shouldn't further complicate the platform stuff, haha, it's actually partly why I asked O:). |
I made a bunch of changes so this is now true. All the examples contain at most |
This is still linked in the manual, should be removed if closed. |
Hello, I'm a bot and I thank you in the name of the community for opening this issue. To help our human contributors focus on the most-relevant reports, I check up on old issues to see if they're still relevant. This issue has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human. The community would appreciate your effort in checking if the issue is still valid. If it isn't, please close it. If the issue persists, and you'd like to remove the stale label, you simply need to leave a comment. Your comment can be as simple as "still important to me". If you'd like it to get more attention, you can ask for help by searching for maintainers and people that previously touched related code and @ mention them in a comment. You can use Git blame or GitHub's web interface on the relevant files to find them. Lastly, you can always ask for help at our Discourse Forum or at #nixos' IRC channel. |
Still important to me |
I can take a look at this once #105364 is merged. |
@Ericson2314 @Profpatsch Is this still an issue? Can the reference in the manual be deleted? |
If we can merge #107214, and (better still) rearrange |
Added the checkboxes for those. |
@siraben OK, just the final coding step (and manual victor lap) remains. If you want to take a stab at this, that would be much appreciated! |
This issue is still referenced in the manual BTW |
Simply put, I should be able to do
and that should work. I could make it work right now with a dirty white-list and fall-backs, but that's kind of defeats the point.
Currently, the biggest culprits are
withTLS
andopenssl.system
. See https://github.com/NixOS/nixpkgs/blob/master/lib/systems/examples.nixplatform
field, see https://github.com/NixOS/nixpkgs/blob/master/lib/systems/platforms.nixarch
which overlaps with the far more principledparsed,arch
. Seeelaborate
https://github.com/NixOS/nixpkgs/blob/master/lib/systems/default.nix#L17.The general design issue is we need to handle the per-package random crap in a more modular way, without giving up the possibility of the user to override with their own values. My GNU ld emulation picking logic at https://github.com/NixOS/nixpkgs/blob/master/pkgs/build-support/bintools-wrapper/default.nix#L167-L179 is certainly in a more modular location, but also cannot be nicely overridden.
Checklist
withTLS
bigEndian
,openssl.system
platforms
for no good reasonconfig
is enough in more cases.platforms.nix
andexamples.nix
platforms.nix
and partly inexamples.nix
, that is just confusing.config
is usually enough, and remove the reference to this issue.CC @dtzWill @dezgeg @infinisil @teto
The text was updated successfully, but these errors were encountered: