Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Firefox package (59.0.2) is missing icon in 18.03 #38536

Closed
cx405 opened this issue Apr 7, 2018 · 4 comments
Closed

Firefox package (59.0.2) is missing icon in 18.03 #38536

cx405 opened this issue Apr 7, 2018 · 4 comments

Comments

@cx405
Copy link

cx405 commented Apr 7, 2018 •
edited
Loading

Issue description

Firefox package in 18.03-stable contains no icon and none is displayed.
This is because /nix/store/4ps5j72qc21sib7m7h5mmm4zbj5i5q4f-firefox-59.0.2/share/icons/hicolor/128x128/apps/ contains no files, but should contain firefox.png icon, because /nix/store/4ps5j72qc21sib7m7h5mmm4zbj5i5q4f-firefox-59.0.2/share/applications/firefox.desktop references Icon=firefox .
@cx405 cx405 changed the title Firefox package ( 59.0.2 is missing icon Firefox package (59.0.2) is missing icon Apr 7, 2018
@cx405 cx405 changed the title Firefox package (59.0.2) is missing icon Firefox package (59.0.2) is missing icon in 18.03 Apr 7, 2018
@jtojnar
Copy link
Member

jtojnar commented Apr 7, 2018

Perhaps #37636 needs backporting

@cx405
Copy link
Author

cx405 commented Apr 7, 2018

@jtojnar Indeed, that would solve the issue.
/run/current-system/sw/lib/firefox/browser/chrome/icons/default/ contains all the icon files (default{16,32,48,64,128}.png) in my live system, but they are linked to /run/current-system/sw/lib/firefox/browser/icons/ (notice the absent "chrome") according to https://github.com/NixOS/nixpkgs/blob/staging-18.03/pkgs/applications/networking/browsers/firefox/wrapper.nix

Thank you very much for cross-finding this!

@cx405 cx405 mentioned this issue Apr 7, 2018
Merged
8 tasks
@alexeymuranov
Copy link
Contributor

alexeymuranov commented Apr 15, 2018 •
edited
Loading

My Firefox icon disappeared still with 17.09. Today i restarted Gnome Shell, and icons for Chromium, Geary, and VLC are now gone as well.

vcunat pushed a commit that referenced this issue May 20, 2018
@vcunat
Merge #37636: wrapFirefox: update icon location
eb5a7a5 
(cherry picked from commit 6ca5577)
Fixes #38536.
@vcunat
Copy link
Member

vcunat commented May 20, 2018

Right, fixed for me as well; backported as eb5a7a5.

@vcunat vcunat closed this as completed May 20, 2018
@alexeymuranov alexeymuranov mentioned this issue Sep 2, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jtojnar @alexeymuranov @vcunat @cx405