Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metrics job issues #76776

Closed
2 of 3 tasks
vcunat opened this issue Jan 1, 2020 · 2 comments
Closed
2 of 3 tasks

metrics job issues #76776

vcunat opened this issue Jan 1, 2020 · 2 comments
Labels
0.kind: bug Something is broken

Comments

@vcunat
Copy link
Member

vcunat commented Jan 1, 2020 •
edited
Loading

My wishlist; feel free to start on some of these yourself:

  • fix master with nix 2.3; it works with nix 2.2.2: example (I had to downgrade that Hydra builder for now)

  • investigate avoiding the impurity from the builder's nix version. It just makes debugging the failures harder, e.g. now people (with nix >= 2.3) will be getting different errors than the Hydra job.

  • investigate getting better error outputs from the job. IIRC now isn't an exception when you see

    parse error: Invalid numeric literal at line 1, column 6

    without a good hint of what's wrong (at least what file is referred to).
@vcunat vcunat added the 0.kind: bug Something is broken label Jan 1, 2020
@stale
Copy link

stale bot commented Jun 30, 2020

Thank you for your contributions.

This has been automatically marked as stale because it has had no activity for 180 days.

If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.

Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse.
  3. Ask on the #nixos channel on irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 30, 2020
vcunat added a commit that referenced this issue Mar 28, 2021
@vcunat
metrics: drop requiredSystemFeatures; /cc #76776
c7aef6d 
The build hasn't worked for months (even on 20.09).  Now also my
dedicated machine broke, and I don't feel like maintaining it until
the job has any chance of succeeding.
(I don't know why exactly it's failing.)
vcunat added a commit that referenced this issue Mar 28, 2021
@vcunat
metrics: drop requiredSystemFeatures; /cc #76776
f32d08a 
The build hasn't worked for months (even on 20.09).  Now also my
dedicated machine broke, and I don't feel like maintaining it until
the job has any chance of succeeding.
(I don't know why exactly it's failing.)

(cherry picked from commit c7aef6d)
Additionally marked as broken; it seems unlikely to get fixed on 20.09
before it gets fixed on master.
@edolstra edolstra mentioned this issue Sep 27, 2021
Merged
12 tasks
@stale stale bot removed 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md labels Sep 27, 2021
edolstra added a commit that referenced this issue Sep 28, 2021
@edolstra
Fix metrics job
39d038d 
It was failing because the pager wasn't set, causing the message

  error: executing '': No such file or directory

to pollute the JSON output.

https://hydra.nixos.org/build/154768851

Issue #76776.
vcunat added a commit that referenced this issue Nov 14, 2021
@vcunat
Revert "metrics: drop requiredSystemFeatures; /cc #76776"
30e1b0b 
This reverts commit c7aef6d.

I believe it should work again since today, though I'm being a bit
conservative, pushing to `staging-next` instead of `master`.
@vcunat
Copy link
Member Author

vcunat commented Nov 14, 2021

I think issues around this are solved now. Anyway, a freshly open one would be probably better for anything that remains.

@vcunat vcunat closed this as completed Nov 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0.kind: bug Something is broken
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vcunat