-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
imgbrd-grabber: init at 7.3.2 #101048
imgbrd-grabber: init at 7.3.2 #101048
Conversation
Think I figured out what was wrong with the source builds. |
Changes have been pushed. |
@jonringer Any thoughts on the transition from binary -> source builds here? Sort of paranoid on whether I'm missing anything else, or if the |
Result of 1 package built:
did a quick test and it seems to work as well as it did on arch |
Result of 1 package built:
|
just noticed that you forgot to add the meta section |
Motivation for this change
imgbrd-grabber: "Very customizable imageboard/booru downloader with powerful filenaming features."
Closes #67632
Can be sourced by Hydrus once #101034 is merged.
Things Done
I only considered the Linux application but I doubt it would be much work to get things working on macOS.
Notes
I initially tried to build from source, but the build usesnpm install
for sites module.Additionally, thepackage.json
does not contain aversion
(required for node2nix), so I settled on packaging the binary application for now.Update:
I have pushed an expression that builds the application from source.
Bugs
With
7.3.2
,Grabber-cli
crashes when used.This is solved by Bionus/imgbrd-grabber@3814631.
This has not yet been merged, and the patch does not apply cleanly on top of
7.3.2
.For more information, see the issue.
cc @klorophatu @toyo-chi @hyarsan @deliciouslytyped