Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apple_sdk: 10.12 -> 10.13 #101940

Closed
wants to merge 1 commit into from
Closed

apple_sdk: 10.12 -> 10.13 #101940

wants to merge 1 commit into from

Conversation

SuperSandro2000
Copy link
Member

Motivation for this change

Closes #101229

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000 SuperSandro2000 mentioned this pull request Oct 28, 2020
Closed
@SuperSandro2000 SuperSandro2000 changed the base branch from master to staging October 28, 2020 15:46
@SuperSandro2000
Copy link
Member Author

I changed the target branch to staging because we are rebuilding basically everything.

LnL7
LnL7 reviewed Oct 28, 2020
View reviewed changes
Copy link
Member

@LnL7 LnL7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't include any apple source releases which are most likely also needed and the tricky part of bumping the sdk version.

@SuperSandro2000 SuperSandro2000 mentioned this pull request Nov 4, 2020
Closed
15 tasks
@r-burns
Copy link
Contributor

r-burns commented Nov 26, 2020

@LnL7 What's tricky about the apple source releases? Is there something non-experts (like me) can do to help out with the update?

@LnL7
Copy link
Member

LnL7 commented Nov 26, 2020

Hard to say anything specific. Just in general these components are often only partially opensourced and the fact that we don't use xcode or whatever apple uses internally makes things usually a bit more complicated compared to projects with an actual opensource community.

For reference this where the changes for 10.12 #56744 (e6f7f29).

Updating CF is probably one of the main things that's missing, along with some other core parts like Libc, Libsystem, etc. Those will probably drive most of the other changes needed based on what problems arise from updating those.

@siraben
Copy link
Member

siraben commented Dec 13, 2020

Any updates on this PR?

@SuperSandro2000
Copy link
Member Author

SuperSandro2000 commented Dec 20, 2020 •
edited
Loading

Any updates on this PR?

I currently do not have more plans to work on this right now. If anyone is interested feel free to start from here.

Basically everything on https://opensource.apple.com/release/macos-10136.html needs also an update.

@prusnak prusnak mentioned this pull request Dec 23, 2020
Closed
@stale
Copy link

stale bot commented Jun 18, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 18, 2021
@SuperSandro2000 SuperSandro2000 deleted the apple_sdk-10.13 branch June 23, 2021 16:55
toonn pushed a commit to toonn/nixpkgs that referenced this pull request Oct 5, 2022
@SuperSandro2000 @toonn
apple_sdk: 10.12 -> 10.13
d6de028 
Based on NixOS#101940.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r-burns r-burns r-burns left review comments

@LnL7 LnL7 LnL7 left review comments

Assignees
No one assigned
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: stdenv Standard environment 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update macOS SDK
4 participants
@SuperSandro2000 @r-burns @LnL7 @siraben