Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cc-wrapper: fix wrapper tests and building for darwin on staging-next #107336

Closed
wants to merge 3 commits into from
Closed

cc-wrapper: fix wrapper tests and building for darwin on staging-next #107336

wants to merge 3 commits into from

Commits on Dec 21, 2020

  1. cc-wrapper: disable dynamic linker for darwin 

    Disable the dynamic linker if the platform is darwin. On darwin the
dynamic linker cannot be passed using the -dynamic-linker argument, but
needs to be explicitly set via environment variables. Passing the linker
via -dynamic-linker results in an error:

  ld: unknown option: -dynamic-linker=/usr/lib/dyld

Pass a isdarwin variable to the build script and disable the linker on
darwin systems.
    @Emantor
    Emantor committed Dec 21, 2020
    Configuration menu
    Copy the full SHA
    f6584a3 View commit details
    Browse the repository at this point in the history

  2. cc-wrapper: useGccForLibs for libcxx == null 

    Since commit 11302dc ("clang, cc-wrapper: Move `--gcc-toolchain`
logic into CC wrapper") --gcc-toolchain was only passed i useGccForLibs
is true. However useGccForLibs is disabled if libcxx is null, which
results in the libcxxStdenv failing, since the linker can't find libgcc
while linking. Remove the condition check for libcxx == null, to let the
wrapper tests pass again.
    @Emantor
    Emantor committed Dec 21, 2020
    Configuration menu
    Copy the full SHA
    708cb80 View commit details
    Browse the repository at this point in the history

  3. fixup! cc-wrapper: disable dynamic linker for darwin

    @Emantor
    Emantor committed Dec 21, 2020
    Configuration menu
    Copy the full SHA
    7b4f7da View commit details
    Browse the repository at this point in the history