jetbrains: replace overrideDerivation with overrideAttr #107344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raboof
force-pushed
the
jetbrains-replace-overrideDerivation-with-overrideAttr
branch
from
4c62759
to
e36c68e
Compare
This fixes error-checking of function arguments ( https://nixos.org/manual/nixpkgs/stable/#sec-pkg-overrideDerivation), notably checking the license (NixOS#107250)
raboof
force-pushed
the
jetbrains-replace-overrideDerivation-with-overrideAttr
branch
from
e36c68e
to
e794c8c
Compare
raboof
force-pushed
the
jetbrains-replace-overrideDerivation-with-overrideAttr
branch
from
e794c8c
to
75641c0
Compare
ofborg
bot
added
10.rebuild-darwin: 0
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
|
(I created this PR, so naturally I'm in favor ;) ) |
hugolgst
approved these changes
Jan 22, 2021
I was looking for another maintainer which can confirm that this works and does not break anything. |
|
Result of |
jonringer
approved these changes
Feb 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This fixes error-checking of function arguments (
https://nixos.org/manual/nixpkgs/stable/#sec-pkg-overrideDerivation),
notably checking the license (#107250)
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)