Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdrangel: set SOAPYSDR_DIR in build #107359

Merged
merged 1 commit into from
Dec 22, 2020
Merged

Conversation

numinit
Copy link
Contributor

@numinit numinit commented Dec 22, 2020

Motivation for this change

sdrangel has some strange logic for finding SoapySDR in its cmake script. If cmake locates soapysdr, the UI components for soapysdr will be compiled but the plugins won't be. Setting SOAPYSDR_DIR makes sure the plugins are compiled too.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@numinit
Copy link
Contributor Author

numinit commented Dec 22, 2020

Confirmed working end to end with a local SoapySDR server.

@ofborg ofborg bot requested a review from alkeryn December 22, 2020 01:35
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Dec 22, 2020
@markuskowa markuskowa merged commit f62fcde into NixOS:master Dec 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants