-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a way to pin a NixOS version within the module system. #11106
Conversation
@copumpkin Yes, this solves #7467. |
👍 |
The latest patch add documentation for the module and a changelog entry. The only remaining part is to add the test into the test infrastructure. |
@nbp Nice approach, looks good to me. |
nixos.extraModules = [ "./${config.networking.hostname}" ] | ||
if config.networking.hostname == "server" then | ||
[ ./server.nix ] else [ ./client.nix ]; | ||
</programlisting> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this example correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, this is a mix of 2 idea, I will keep the bottom one for now.
This modification add a way to re-evaluate the module system with a different version of NixOS, or with a different set of arguments.
Add a way to pin a NixOS version within the module system.
🍻 |
🤗
|
nice, thanks :) |
Sounds useful 👍 |
These changes got reverted in commit d4636fa |
@edolstra while in general the
I don't know if this is the implementation we'll end up using, but do you agree that given the above this is at least something that's nice to have, even given the existence of cc @grahamc given his interest in NixOS/nixops#649 |
This modification add a way to re-evaluate the module system with a
different version of NixOS, or with a different set of arguments.
cc @garbas