Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[staging-next] pythonPackages.ddt: fix tests #112055

Merged
merged 1 commit into from
Feb 7, 2021
Merged

[staging-next] pythonPackages.ddt: fix tests #112055

merged 1 commit into from
Feb 7, 2021

Conversation

dotlambda
Copy link
Member

@dotlambda dotlambda commented Feb 5, 2021 •
edited
Loading

Motivation for this change

#110525 (comment)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dotlambda dotlambda changed the title pythonPackages.ddt: fix tests [staging] pythonPackages.ddt: fix tests Feb 5, 2021
@dotlambda dotlambda changed the base branch from staging to staging-next February 6, 2021 13:49
@dotlambda dotlambda changed the title [staging] pythonPackages.ddt: fix tests [staging-next] pythonPackages.ddt: fix tests Feb 6, 2021
@dotlambda dotlambda requested a review from mweinelt February 6, 2021 18:31
@mweinelt mweinelt merged commit b22e3ad into NixOS:staging-next Feb 7, 2021
@dotlambda dotlambda deleted the ddt-pyyaml branch February 7, 2021 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@mweinelt mweinelt Awaiting requested review from mweinelt

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dotlambda @mweinelt