Spotifyd rust packages

[jshcmpbll]

Motivation for this change

Spotifyd v0.3.0 does not work - Caught panic with message: attempted to zero-initialize type `librespot_tremor::tremor_sys::ov_callbacks`, which is invalid Caught panic with message: called `Result::unwrap()` on an `Err` value: "SendError(..)" Player thread panicked!

According to this issue its due to the latest rust version. Pining the version of rust back to rustPackages_1_45 fixes this error.

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Ensured that relevant documentation is up to date
• Fits CONTRIBUTING.md.

[r-rmcgibbo]

Result of nixpkgs-review pr 114309 at dcccf49c run on aarch64-linux 1

1 package built:

• spotifyd

1 suggestion:

• warning: unclear-gpl

  gpl3 is a deprecated license, check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.

  Near pkgs/applications/audio/spotifyd/default.nix:42:5:

     |
  42 |     license = with licenses; [ gpl3 ];
     |     ^
  

---

Result of nixpkgs-review pr 114309 at dcccf49c run on x86_64-linux 1

1 package built:

• spotifyd

1 suggestion:

• warning: unclear-gpl

  gpl3 is a deprecated license, check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.

  Near pkgs/applications/audio/spotifyd/default.nix:42:5:

     |
  42 |     license = with licenses; [ gpl3 ];
     |     ^
  

[andir]

Just to add some historical context here (who knows how long this will continue to happen):
I first applied the fix that was applied here (again) in #106050 which got removed in #109681 for no reason that I can see. We now also lack any kind of documentation in the source code why that older rustc is desired. History tells me someone will try to compile with the latest and greatest, sees no compiler errors and will open a PR that will bump the version again.

[jshcmpbll]

@andir Very good point and I apologize for not adding a comment in the code for future contributors to validate the package not just compiles but works.

I was talking with @sarcasticadmin yesterday and he mentioned there should be some unit testing around this to prevent these issues in the future. I don't have much experience in that but its definitely something I'd like to learn more about and am willing to give it a shot.

[andir]

As this requires a closed source backend I am not sure how to validate it outside of the sandbox.

[bnjmnt4n]

Just to update: it seems like a version which fixes the original issue has been merged and released as v0.3.1 (see Spotifyd/spotifyd#900), although we might want to wait for Spotifyd/spotifyd#912 before updating.