Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ispc: 1.13.0 -> unstable-2021-04-02 #118418

Merged
merged 1 commit into from
Apr 5, 2021
Merged

ispc: 1.13.0 -> unstable-2021-04-02 #118418

merged 1 commit into from
Apr 5, 2021

Conversation

erictapen
Copy link
Member

Motivation for this change
Things done

Using LLVM 11 brings a problem: 11.1 broke the build for ISPC so we could use latest ISPC main branch for now, or wait until the new ISPC release?

Also had to patch a cmake script. Opened a PR upstream: ispc/ispc#2055

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@erictapen erictapen mentioned this pull request Apr 3, 2021
Merged
10 tasks
SuperSandro2000
SuperSandro2000 requested changes Apr 3, 2021
View reviewed changes
pkgs/development/compilers/ispc/default.nix Outdated
@@ -7,15 +7,27 @@

stdenv.mkDerivation rec {
pname = "ispc";
version = "1.13.0";
version = "1.15.0.2021-04-02";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is not a valid version number. Please use unstable-XXXX-XX-XX.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

pkgs/development/compilers/ispc/default.nix Show resolved Hide resolved
@erictapen erictapen changed the title ispc: 1.13.0 -> 1.15.0.2021-04-02 ispc: 1.13.0 -> unstable-2021-04-02 Apr 3, 2021
@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 118418 at 92e6442 run on x86_64-linux 1

2 packages skipped due to time constraints:
  • blender
  • embree2
4 packages built successfully:
  • embree
  • ispc
  • luxcorerender
  • openimagedenoise

@risicle
Copy link
Contributor

risicle commented Apr 4, 2021

nixpkgs-review happy for me, macos 10.14

@risicle
Copy link
Contributor

risicle commented Apr 4, 2021

@ofborg build openimagedenoise luxcorerender

@SuperSandro2000 SuperSandro2000 merged commit 5d2f7bc into NixOS:master Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

@aristidb aristidb Awaiting requested review from aristidb

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@erictapen @r-rmcgibbo @risicle @SuperSandro2000