Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor julia 1.6 #118483

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Refactor julia 1.6 #118483

wants to merge 1 commit into from

Conversation

cstich
Copy link
Contributor

@cstich cstich commented Apr 4, 2021

This compiles julia 1.6 from source. So far it skips all the tests and I know those need more work. I based it off the recent refactor of julia 1.0 (#117881)

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • [X ] NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@cstich cstich mentioned this pull request Apr 4, 2021
Closed
10 tasks
samuela
samuela reviewed Apr 4, 2021
View reviewed changes
pkgs/development/compilers/julia/precompile_succeeded.patch
@@ -0,0 +1,156 @@
{ fetchzip, fetchFromGitHub, lib, pkgs, stdenv
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file looks the same as 1.6.nix. Am I missing something?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am currently traveling so I didn't have time to compare this with the other pull request. I was thinking maybe bits and bobs of this one might be still useful to someone.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No rush! I just meant that this doesn't look like a patch file. It looks more like the 1.6.nix file from this PR, but perhaps I'm missing something!

samuela
samuela reviewed Apr 4, 2021
View reviewed changes
pkgs/top-level/all-packages.nix
@@ -10717,6 +10717,10 @@ in
inherit (darwin.apple_sdk.frameworks) CoreServices ApplicationServices;
};

julia_16 = callPackage ../development/compilers/julia/1.6.nix {
inherit (darwin.apple_sdk.frameworks) CoreServices ApplicationServices;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like these inputs are no longer needed in the derivation? It looks like they've been commented out so they can prob be removed here as well.

@samuela samuela mentioned this pull request Apr 4, 2021
Closed
@ghost ghost mentioned this pull request Apr 13, 2021
Merged
10 tasks
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/need-special-build-of-nightly-julia-version/14504/4

@stale
Copy link

stale bot commented Apr 17, 2022

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Apr 17, 2022
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Mar 20, 2024
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 20, 2024
@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuela samuela samuela left review comments

Assignees
No one assigned
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cstich @nixos-discourse @samuela @wegank