Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rust: Bootstrap riscv64 #125132

Merged
merged 3 commits into from
Jun 1, 2021
Merged

rust: Bootstrap riscv64 #125132

merged 3 commits into from
Jun 1, 2021

Conversation

zhaofengli
Copy link
Member

Motivation for this change

Bootstraps Rust native compilation on riscv64. The LLVM test suite needs to be disabled on RISC-V due to several failing tests (see commit message).

This depends on #115406 to actually work but can probably be merged now as it doesn't affect other platforms. Tested by building rustc and cargo on native riscv64.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Added a release notes entry if the change is major or breaking
  • Fits CONTRIBUTING.md.

@zhaofengli
llvmPackages: Use at least LLVM 9 for RISC-V
55aaec1
@zhaofengli
llvm{9,11}: Disable tests on RISC-V
8f80568 
The test suite leads to nothing but tears, sorrow, and wasted build
time. It probably should be disabled for all of them but doing only
9 (llvmPackages) and 11 (llvmPackages_latest, Rust) for now. Some of
the failures have been fixed in LLVM main:

- https://reviews.llvm.org/D97490
- https://reviews.llvm.org/D91043
@zhaofengli
rust: Add support for riscv64
6288319
@zhaofengli zhaofengli mentioned this pull request Jun 1, 2021
Merged
9 tasks
@Mic92 Mic92 merged commit 97098e5 into NixOS:master Jun 1, 2021
@zhaofengli zhaofengli deleted the rust-riscv branch June 1, 2021 05:08
@zhaofengli zhaofengli mentioned this pull request Jun 2, 2021
Closed
@zhaofengli zhaofengli mentioned this pull request Jun 11, 2021
Merged
11 tasks
zhaofengli added a commit to zhaofengli/nixpkgs that referenced this pull request Jan 5, 2022
@zhaofengli
llvmPackages_{10,12,13}: Disable tests on RISC-V
485c05a 
Same rationale in NixOS#125132.
zhaofengli added a commit to zhaofengli/nixpkgs that referenced this pull request Mar 14, 2022
@zhaofengli
llvmPackages_{10,12,13}: Disable tests on RISC-V
da22448 
Same rationale in NixOS#125132.
zhaofengli added a commit to zhaofengli/nixpkgs that referenced this pull request Jan 9, 2023
@zhaofengli
llvmPackages_{10,12,13}: Disable tests on RISC-V
b045264 
Same rationale in NixOS#125132.
@zhaofengli zhaofengli mentioned this pull request Jan 20, 2023
Open
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 Awaiting requested review from LnL7

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@Mic92 Mic92 Awaiting requested review from Mic92 Mic92 is a code owner

@zowoq zowoq Awaiting requested review from zowoq zowoq is a code owner

Assignees
No one assigned
Labels
6.topic: rust 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhaofengli @Mic92