Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "nixos/wireless: make wireless.interfaces mandatory" #126075

Merged
merged 2 commits into from
Jun 8, 2021
Merged

Revert "nixos/wireless: make wireless.interfaces mandatory" #126075

merged 2 commits into from
Jun 8, 2021

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Jun 7, 2021 •
edited
Loading

Motivation for this change

Only warn, not fail, when no wireless interfaces are configured.
Thix fixes the breakage caused by #125288, #125917.

Things done
  • Tested in the NixOS installer
  • Tested in a VM
  • 21.11 Release Notes
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

cc @grahamc @jonringer

@rnhmjoj rnhmjoj added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 1.severity: channel blocker Blocks a channel labels Jun 7, 2021
@rnhmjoj rnhmjoj requested a review from ryantm as a code owner June 7, 2021 14:32
@github-actions github-actions bot added 8.has: changelog 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` labels Jun 7, 2021
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jun 7, 2021
@rnhmjoj rnhmjoj mentioned this pull request Jun 7, 2021
Merged
jonringer
jonringer approved these changes Jun 7, 2021
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @grahamc

@rnhmjoj
nixos/wireless: only warn for no interfaces
be01320 
A hard failure breaks the NixOS installer, which can't possibly
know the interface names in advance.
@lukegb lukegb merged commit 631250e into NixOS:master Jun 8, 2021
@jonringer jonringer added the 8.has: port to stable A PR already has a backport to the stable release. label Jun 8, 2021
@rnhmjoj rnhmjoj deleted the fixup branch July 10, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@lukegb lukegb lukegb approved these changes

@ryantm ryantm Awaiting requested review from ryantm

Assignees
No one assigned
Labels
1.severity: channel blocker Blocks a channel 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rnhmjoj @lukegb @jonringer