-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zfs: add latestCompatibleLinuxPackages option #126980
Conversation
This Looks good to me. |
I saw people repeatedly asking for this, so a backport is probably a good idea. |
I should probably add a release note, otherwise I think it's merge-able |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not as general as @xaverdh's solution but a net improvement and definitely not controversial.
Should a more general solution land later, it should be simple to implement this special case with it.
Needs a rebase @jonringer but after that it's ready to merge IMO.
Looks like it's |
f99b568
to
6115168
Compare
b88b1ca
to
3fad103
Compare
Can we get this merged? I'd appreciate getting away from using a frankenbuild of unstable/master/PRs soon. |
3fad103
to
f6ad3e1
Compare
@jonringer do you need more feedback on this one? Or is there anything that can be done to help? |
I'll resolve the conflicts then merge when ofborg is green. |
f6ad3e1
to
fd7dcd2
Compare
going to wait for ofborg |
Backport failed for Please cherry-pick the changes locally. git fetch origin release-21.05
git worktree add -d .worktree/backport-126980-to-release-21.05 origin/release-21.05
cd .worktree/backport-126980-to-release-21.05
git checkout -b backport-126980-to-release-21.05
ancref=$(git merge-base e8a41956a7a1ffed308d497f456d25bb2d3a5dbe fd7dcd2cf4ada16d40a39856204fc2b8f16a4aed)
git cherry-pick -x $ancref..fd7dcd2cf4ada16d40a39856204fc2b8f16a4aed |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
Motivation for this change
It's been brought up that people would like some way to more easily determine the latest compatible version with zfs.
This is a compromise in not being able to do so at all, to being able to determine the latest given all module restrictions. Just add something specifically to zfs itself.
example usage:
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)