Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gtest: 1.10.0 -> 1.11.0 #130272

Merged
merged 1 commit into from
Jul 29, 2021
Merged

gtest: 1.10.0 -> 1.11.0 #130272

merged 1 commit into from
Jul 29, 2021

Conversation

mikepurvis
Copy link
Contributor

@mikepurvis mikepurvis commented Jul 15, 2021

Motivation for this change

The 1.11 release contains google/googletest#3094, which silences a nuisance CMake warning that otherwise comes up in every package using the gtest CMake module:

CMake Deprecation Warning at googletest/googletest/CMakeLists.txt:56 (cmake_minimum_required):
  Compatibility with CMake < 2.8.12 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value or use a ...<max> suffix to tell
  CMake that the project does not need compatibility with older versions.

One of the patches can also be dropped as the change from google/googletest#2491 is incorporated.

Things done

I've been building this locally from an override for several weeks with robotics/ROS-related packages, and have experienced no issues.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Relase notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot removed 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 6.topic: erlang 6.topic: kernel The Linux kernel 6.topic: lua 8.has: documentation 6.topic: golang 6.topic: ocaml 6.topic: steam labels Jul 15, 2021
@SuperSandro2000 SuperSandro2000 changed the base branch from master to staging July 15, 2021 16:57
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: documentation 8.has: module (update) This PR changes an existing module in `nixos/` labels Jul 15, 2021
@github-actions github-actions bot removed 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: changelog labels Jul 15, 2021
@FRidh FRidh merged commit 380301f into NixOS:staging Jul 29, 2021
@mikepurvis mikepurvis deleted the patch-3 branch July 31, 2021 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants