Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ecl: make sure boehmgc is available to gcc/linker #132269

Merged
merged 1 commit into from
Aug 1, 2021

Conversation

collares
Copy link
Member

@collares collares commented Aug 1, 2021

Motivation for this change

Since #131719, maxima-ecl is built with strictDeps = true. When ecl is built with useBoehmgc = true, libgc's headers, which were previously found by virtue of boehmgc being in propagatedBuildInputs, no longer get appended to the include path. A similar thing happens for linker flags.

This PR fixes the Sage build.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Relase notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@collares
Copy link
Member Author

collares commented Aug 1, 2021

Result of nixpkgs-review pr 132269 run on x86_64-linux 1

5 packages built:
  • ecl
  • eql
  • maxima-ecl
  • sage (sagemath)
  • sageWithDoc

@r-rmcgibbo
Copy link

r-rmcgibbo commented Aug 1, 2021

Result of nixpkgs-review pr 132269 at 75b4fcc run on aarch64-linux 1

3 packages built successfully:
  • ecl
  • eql
  • maxima-ecl

Result of nixpkgs-review pr 132269 at 75b4fcc run on x86_64-linux 1

2 packages skipped due to time constraints:
  • sage
  • sageWithDoc
3 packages built successfully:
  • ecl
  • eql
  • maxima-ecl
5 suggestions:
  • warning: build-tools-in-build-inputs

    autoconf is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

    Near pkgs/development/compilers/ecl/default.nix:32:10:

       |
    32 |   inherit buildInputs propagatedBuildInputs;
       |          ^
    
  • warning: build-tools-in-build-inputs

    automake is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

    Near pkgs/development/compilers/ecl/default.nix:32:10:

       |
    32 |   inherit buildInputs propagatedBuildInputs;
       |          ^
    
  • warning: build-tools-in-build-inputs

    makeWrapper is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

    Near pkgs/development/compilers/ecl/default.nix:32:10:

       |
    32 |   inherit buildInputs propagatedBuildInputs;
       |          ^
    
  • warning: name-and-version

    Did you mean to pass pname instead of name to mkDerivation?

    Near pkgs/development/compilers/ecl/default.nix:31:14:

       |
    31 |   inherit (s) name version;
       |              ^
    

    Near pkgs/development/compilers/ecl/default.nix:31:14:

       |
    31 |   inherit (s) name version;
       |              ^
    
  • warning: build-tools-in-build-inputs

    libtool is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

    Near pkgs/development/compilers/ecl/default.nix:32:10:

       |
    32 |   inherit buildInputs propagatedBuildInputs;
       |          ^
    

@Mic92 Mic92 merged commit 6300316 into NixOS:master Aug 1, 2021
@collares collares deleted the ecl-boehmgc branch August 1, 2021 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants