Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 21.05] override twisted 20.3.0 -> 21.7.0 for matrix-synapse #135296

Merged
merged 2 commits into from
Aug 23, 2021
Merged

[Backport 21.05] override twisted 20.3.0 -> 21.7.0 for matrix-synapse #135296

merged 2 commits into from
Aug 23, 2021

Conversation

mguentner
Copy link
Contributor

Motivation for this change

PRs for master:

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.
  • Deployed to several instances running matrix-synapse: ✔️

@mguentner mguentner requested a review from Ma27 August 22, 2021 14:41
@github-actions github-actions bot added the 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS label Aug 22, 2021
@mguentner mguentner force-pushed the backport_21_05_twisted_21_07_for_matrix_synapse branch from e05007a to f75441c Compare August 22, 2021 14:42
@mguentner
nixos/tests/matrix-synapse: add email regression test case
e6e8fe7 
twisted is used in matrix-synapse for smtp handling.
Mostly this is used for password resets, but also notifications
are delivered that way.

older versions of twisted require the e-mail server to
have TLS1.0 enabled.

Obviously, quite a lot of servers have this disabled which means
synapse won't be able to deliver mails using such servers.

matrix-synapse issue:

matrix-org/synapse#6211
@mguentner
matrix-synapse: override twisted 20.3.0 -> 21.7.0
e9d6163 
see upstream issues:

twisted/twisted#1225 (comment)
matrix-org/synapse#6211
@mguentner mguentner force-pushed the backport_21_05_twisted_21_07_for_matrix_synapse branch from f75441c to e9d6163 Compare August 22, 2021 14:46
@ofborg ofborg bot requested review from fadenb, Ekleog, mjlbach and Ralith August 22, 2021 14:56
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Aug 22, 2021
@r-rmcgibbo
Copy link

r-rmcgibbo commented Aug 23, 2021 •
edited
Loading

Result of nixpkgs-review pr 135296 at e9d6163 run on aarch64-linux 1

5 packages built successfully:
  • matrix-synapse
  • matrix-synapse-plugins.matrix-synapse-ldap3
  • matrix-synapse-plugins.matrix-synapse-mjolnir-antispam
  • matrix-synapse-plugins.matrix-synapse-pam
  • matrix-synapse-plugins.matrix-synapse-shared-secret-auth

Result of nixpkgs-review pr 135296 at e9d6163 run on x86_64-linux 1

5 packages built successfully:
  • matrix-synapse
  • matrix-synapse-plugins.matrix-synapse-ldap3
  • matrix-synapse-plugins.matrix-synapse-mjolnir-antispam
  • matrix-synapse-plugins.matrix-synapse-pam
  • matrix-synapse-plugins.matrix-synapse-shared-secret-auth

@Ma27 Ma27 merged commit 4fc6d88 into NixOS:release-21.05 Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Awaiting requested review from Ma27

@fadenb fadenb Awaiting requested review from fadenb

@Ekleog Ekleog Awaiting requested review from Ekleog

@mjlbach mjlbach Awaiting requested review from mjlbach

@Ralith Ralith Awaiting requested review from Ralith

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mguentner @r-rmcgibbo @Ma27