haskell: document branch-off procedure for maintainers #138831
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial documentation of the branch-off procedure with the changes in NixOS#138407 which are yet to be forward-ported.
sternenseemann
requested review from
cdepillabout,
expipiplus1 and
maralorn
12 tasks
sternenseemann
commented
Sep 21, 2021
| them as a PR. | ||
|
|
||
| General information on the release process can be found in the | ||
| [NixOS Releaes Wiki](https://nixos.github.io/release-wiki/Release-Process-Walkthrough.html). |
There was a problem hiding this comment.
Suggested change
| [NixOS Releaes Wiki](https://nixos.github.io/release-wiki/Release-Process-Walkthrough.html). | |
| [NixOS Release Wiki](https://nixos.github.io/release-wiki/Release-Process-Walkthrough.html). |
There was a problem hiding this comment.
Suggested change
| [NixOS Releaes Wiki](https://nixos.github.io/release-wiki/Release-Process-Walkthrough.html). | |
| [NixOS Release Wiki](https://nixos.github.io/release-wiki/Release-Process.html). |
sternenseemann
commented
Sep 21, 2021
| General information on the release process can be found in the | ||
| [NixOS Releaes Wiki](https://nixos.github.io/release-wiki/Release-Process-Walkthrough.html). | ||
|
|
||
| The main objective for `haskellPackages` in the context of stable release |
There was a problem hiding this comment.
Suggested change
| The main objective for `haskellPackages` in the context of stable release | |
| The main objective for `haskellPackages` in the context of stable NixOS |
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
|
Is this still relevant? If it is, it's probably more valuable to have this merged in master than hidden in this PR - even if still incomplete. |
stale
bot
removed
the
2.status: stale
Comment on lines
+298
to
+301
| * On `master` and the release branch, update the `NEXT_NIXOS_RELEASE` | ||
| variable in `maintainers/scripts/haskell/regenerate-hackage-packages.sh`: | ||
| This value should always be the same as what the `.version` file at the | ||
| repository root of the `master` branch contains. |
There was a problem hiding this comment.
This variable doesn't exist in that file anymore.
| them as a PR. | ||
|
|
||
| General information on the release process can be found in the | ||
| [NixOS Releaes Wiki](https://nixos.github.io/release-wiki/Release-Process-Walkthrough.html). |
There was a problem hiding this comment.
Suggested change
| [NixOS Releaes Wiki](https://nixos.github.io/release-wiki/Release-Process-Walkthrough.html). | |
| [NixOS Release Wiki](https://nixos.github.io/release-wiki/Release-Process.html). |
| This value should always be the same as what the `.version` file at the | ||
| repository root of the `master` branch contains. | ||
|
|
||
| * On the release branch, run `maintainers/scripts/haskell/freeze-packages.sh` |
There was a problem hiding this comment.
This script doesn't exist anymore?
|
|
||
| * Make sure the references to the stable release in the documentation are accurate. | ||
|
|
||
| * Document any steps forgotten here! |
There was a problem hiding this comment.
Any more ideas by now?
|
I think we never actually did what the docs say. So merging them without acting on that would be a lie. |
|
This was an idea that was never implemented, see #138407. |
wegank
added
the
2.status: stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Add documentation for the new frozen package workflow in relation to branch-off. This is added to haskell-updates since release-21.05 lacks HACKING.md. The actual changes will be forward ported to unstable after they are finalized and merged into release-21.05.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)