chromedriver: add dbus to libraries, correct LD_LIBRARY_PATH wrapping

[ivan-timokhin]

It is apparently required since version 94.

Fixes #139547

Motivation for this change

Chromedriver doesn’t run otherwise.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• 21.11 Release Notes (or backporting 21.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

[ivan-timokhin]

Incidentally, a couple of questions:

1. Should I add a test to check that chromedriver runs (essentially copy-pasting from the manual), to avoid similar accidents in the future?
2. The resulting wrapper script includes the original LD_LIBRARY_PATH twice (the new value ends with :$LD_LIBRARY_PATH'${LD_LIBRARY_PATH:+':'}$LD_LIBRARY_PATH), so it seems that the explicit reference to $LD_LIBRARY_PATH in wrapProgram invocation is redundant; should I remove it while I’m here?

If there are no obvious downsides to these changes that I’m oblivious to, should they go into this PR or separate ones?

[SuperSandro2000]

Should I add a test to check that chromedriver runs (essentially copy-pasting from the manual), to avoid similar accidents in the future?

If you want to.

The resulting wrapper script includes the original LD_LIBRARY_PATH twice (the new value ends with :$LD_LIBRARY_PATH'${LD_LIBRARY_PATH:+':'}$LD_LIBRARY_PATH), so it seems that the explicit reference to $LD_LIBRARY_PATH in wrapProgram invocation is redundant; should I remove it while I’m here?

Yes please, line 50 should be.

wrapProgram "$out/bin/chromedriver" --prefix LD_LIBRARY_PATH : "${libs}"

If there are no obvious downsides to these changes that I’m oblivious to, should they go into this PR or separate ones?

Just add them to this one.

[ivan-timokhin]

Thanks!

[Artturin]

Suggested change

	passthru.tests = {
	version-check = callPackage ./tests.nix { };
	};
	passthru.tests.version =
	testVersion { package = chromedriver; };

#121896

[ivan-timokhin]

Thank you!

[github-actions]

Successfully created backport PR #139838 for release-21.05.