Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yarn2nix: workaround for NixOS/nix#5128 #141005

Merged
merged 1 commit into from
Oct 10, 2021
Merged

yarn2nix: workaround for NixOS/nix#5128 #141005

merged 1 commit into from
Oct 10, 2021

Conversation

yu-re-ka
Copy link
Contributor

@yu-re-ka yu-re-ka commented Oct 8, 2021

Motivation for this change

NixOS/nix#5128

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@happysalada
Copy link
Contributor

Change looks good, I won't be able to test of my machine because of the git hanging though.

@happysalada
Copy link
Contributor

Happy to merge if you can confirm that you've tested it on one dependency with nix 2.4x

@yu-re-ka
Copy link
Contributor Author

yu-re-ka commented Oct 9, 2021

I have successfully tested this on https://github.com/schildichat/schildichat-desktop/ with Nix unstable/master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants